Re: [PATCH 09/13] net: Move prototype declaration to header fileinclude/net/ipx.h from net/ipx/af_ipx.c

[Josh Triplett]

On Sun, Feb 09, 2014 at 01:33:57AM +0530, Rashika Kheria wrote:
> Move prototype declaration of functions to header file include/net/ipx.h
> from net/ipx/af_ipx.c because they are used by more than one file.
> 
> This eliminates the following warning in 
> net/ipx/ipx_route.c:33:19: warning: no previous prototype for âipxrtr_lookupâ [-Wmissing-prototypes]
> net/ipx/ipx_route.c:52:5: warning: no previous prototype for âipxrtr_add_routeâ [-Wmissing-prototypes]
> net/ipx/ipx_route.c:94:6: warning: no previous prototype for âipxrtr_del_routesâ [-Wmissing-prototypes]
> net/ipx/ipx_route.c:149:5: warning: no previous prototype for âipxrtr_route_skbâ [-Wmissing-prototypes]
> net/ipx/ipx_route.c:171:5: warning: no previous prototype for âipxrtr_route_packetâ [-Wmissing-prototypes]
> net/ipx/ipx_route.c:261:5: warning: no previous prototype for âipxrtr_ioctlâ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx>

Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>

>  include/net/ipx.h |    8 ++++++++
>  net/ipx/af_ipx.c  |    9 ---------
>  2 files changed, 8 insertions(+), 9 deletions(-)
> 
> diff --git a/include/net/ipx.h b/include/net/ipx.h
> index 75466ac..0143180 100644
> --- a/include/net/ipx.h
> +++ b/include/net/ipx.h
> @@ -143,6 +143,14 @@ void ipxitf_down(struct ipx_interface *intrfc);
>  struct ipx_interface *ipxitf_find_using_net(__be32 net);
>  int ipxitf_send(struct ipx_interface *intrfc, struct sk_buff *skb, char *node);
>  __be16 ipx_cksum(struct ipxhdr *packet, int length);
> +int ipxrtr_add_route(__be32 network, struct ipx_interface *intrfc,
> +		     unsigned char *node);
> +void ipxrtr_del_routes(struct ipx_interface *intrfc);
> +int ipxrtr_route_packet(struct sock *sk, struct sockaddr_ipx *usipx,
> +			struct iovec *iov, size_t len, int noblock);
> +int ipxrtr_route_skb(struct sk_buff *skb);
> +struct ipx_route *ipxrtr_lookup(__be32 net);
> +int ipxrtr_ioctl(unsigned int cmd, void __user *arg);
>  
>  static __inline__ void ipxitf_put(struct ipx_interface *intrfc)
>  {
> diff --git a/net/ipx/af_ipx.c b/net/ipx/af_ipx.c
> index 994e28b..e5a00a9 100644
> --- a/net/ipx/af_ipx.c
> +++ b/net/ipx/af_ipx.c
> @@ -84,15 +84,6 @@ DEFINE_SPINLOCK(ipx_interfaces_lock);
>  struct ipx_interface *ipx_primary_net;
>  struct ipx_interface *ipx_internal_net;
>  
> -extern int ipxrtr_add_route(__be32 network, struct ipx_interface *intrfc,
> -			    unsigned char *node);
> -extern void ipxrtr_del_routes(struct ipx_interface *intrfc);
> -extern int ipxrtr_route_packet(struct sock *sk, struct sockaddr_ipx *usipx,
> -			       struct iovec *iov, size_t len, int noblock);
> -extern int ipxrtr_route_skb(struct sk_buff *skb);
> -extern struct ipx_route *ipxrtr_lookup(__be32 net);
> -extern int ipxrtr_ioctl(unsigned int cmd, void __user *arg);
> -
>  struct ipx_interface *ipx_interfaces_head(void)
>  {
>  	struct ipx_interface *rc = NULL;
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/