Re: [PATCH 01/51] CPU hotplug: Provide lockless versions of callbackregistration functions

[Balbir Singh]

On Mon, Feb 10, 2014 at 04:21:30PM +0530, Gautham R Shenoy wrote:
> On Mon, Feb 10, 2014 at 02:45:55PM +0530, Srivatsa S. Bhat wrote:
> 
> +	cpuhp_lock_acquire_read();
>  	mutex_lock(&cpu_hotplug.lock);

Don't you want to abstract cpuhp_lock_acquire_read and mutex_lock into a
more useful primitive. Ditto for the unlock bits - specifically if they
will always be used together.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/