Re: [PATCH] This extends tx_data and and iscsit_do_tx_data with theadditional parameter flags and avoids sending multiple TCP packets iniscsit_fe_sendpage_sg

[Eric Dumazet]

On Mon, 2014-02-10 at 13:01 -0800, Eric Dumazet wrote:
> On Mon, 2014-02-10 at 21:56 +0100, Thomas Glanzmann wrote:
> > Hello Nab,
> > 
> > > This looks correct to me.  Thomas, once your able to confirm please
> > > include your 'Tested-by' and I'll include for the next -rc3 PULL
> > > request.
> > 
> > Eric is currently reviewing our latest iteration with MSG_MORE for
> > kernel_sendmsg and MSG_MORE | MSG_SENDPAGE_NOTLAST for sendpage. However
> > with the last iteration we had again a high RTT for some packets. But
> > than Eric let me tune net.ipv4.tcp_min_tso_segs to 8 and the RTT went
> > down to what it used before auto corking was enabled. At least almost.
> > 
> 
> Hmm.. I was not aware of high RTT for some packets.
> 
> Can you spot this on the pcap you provided ?

offlist

Also please make sure you have this patch :

http://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=4a5ab4e224288403b0b4b6b8c4d339323150c312


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/