Re: [lm-sensors] [PATCH] hwmon: (max6650) Rename the device ids to contain the hwmon suffix
From: Laszlo Papp
Date: Tue Feb 11 2014 - 03:58:52 EST
On Tue, Feb 11, 2014 at 8:50 AM, Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>> >> On Mon, Feb 10, 2014 at 4:38 PM, Jean Delvare <jdelvare@xxxxxxx> wrote:
>> >> > Additionally, dashes are explicitly forbidden in hwmon
>> >> > device names.
>> >>
>> >> Also, where is that documented?
>> >
>> > In Documentation/hwmon/sysfs-interface:
>> >
>> > *********************
>> > * Global attributes *
>> > *********************
>> >
>> > name The chip name.
>> > This should be a short, lowercase string, not containing
>> > spaces nor dashes, representing the chip name. This is
>> > the only mandatory attribute.
>> > I2C devices get this attribute created automatically.
>> > RO
>>
>> Time to revisit this decision....
>>
>> So, based on the fact that children device names usually contain
>> dashes, I do not understand why hwmon would be any special in this
>> regard. It is possible that the hwmon developers have not faced much
>> MFD situation before, and so, this was not considered to be handled
>> like in other subsystems.
>>
>> I am proposing to change this "rule"... Any objection?
>
> Prior to proposing such an invasive change which is highly likely to
> come up against heavy opposition,
It is possible that someone does not understand why you think it may
be invasive, right? Could you please explain the reason for that?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/