Re: [PATCH v2] mfd: MAX6650/6651 support

[Laszlo Papp]

On Tue, Feb 11, 2014 at 11:42 AM, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote:
> On 11 February 2014 17:09, Laszlo Papp <lpapp@xxxxxxx> wrote:
>> On Tue, Feb 11, 2014 at 11:14 AM, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote:
>>> On 11 February 2014 15:40, Laszlo Papp <lpapp@xxxxxxx> wrote:
>>>>>>> [snip]
>>>>>>>> +
>>>>>>>> +struct max665x_dev {
>>>>>>>> +       struct device *dev;
>>>>>>>> +       struct mutex iolock;
>>>>>>>> +
>>>>>>>> +       struct i2c_client *i2c;
>>>>>>>> +       struct regmap     *map;
>>>>>>>> +
>>>>>>>> +       int type;
>>>>>>>
>>>>>>> Unnecessary extra lines above could be removed.
>>>>>>
>>>>>> I prefer it that way, but I will remove the two extra lines as you wish.
>>>>>
>>>>> As I already said, these are just nits and only since you were
>>>>> re-spinning the patch,
>>>>> I suggested them. Also, since this is a new file being added, it
>>>>> avoids further patches
>>>>> doing these same things.
>>>>
>>>> Well, it is worse in my opinion because it makes the code more bloated
>>>> without separation between units, but I made the requested change
>>>> anyway because the feature matters lotta more to me than this styling.
>>>> Hope it is OK now?
>>>
>>> The only thing that you missed among what you agreed to change is the
>>> arrangement of
>>> "depends on" and "select" in Kconfig. Rest look OK. Thanks for taking care.
>>
>> Ah, true. I will do that tomorrow if it is a blocker for the integration.
>
> I don't think it is a blocker in any way and you may choose to ignore
> it as well.

That is alright, Sachin. I will make this change from home. Perhaps,
it is wise anyhow to wait for more feedback, like e.g. from Lee, etc.

Thanks again.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/