Re: [PATCH] block: Fix cloning of discard/write same bios

From: Jens Axboe
Date: Tue Feb 11 2014 - 10:41:31 EST


On Tue, Feb 11 2014, Richard W.M. Jones wrote:
> On Mon, Feb 10, 2014 at 05:45:50PM -0800, Kent Overstreet wrote:
> > Immutable biovecs changed the way bio segments are treated in such a way that
> > bio_for_each_segment() cannot now do what we want for discard/write same bios,
> > since bi_size means something completely different for them.
> >
> > Fortunately discard and write same bios never have more than a single biovec, so
> > bio_for_each_segment() is unnecessary and not terribly meaningful for them, but
> > we still have to special case them in a few places.
> >
> > Signed-off-by: Kent Overstreet <kmo@xxxxxxxxxxxxx>
>
> Tested-by: Richard W.M. Jones <rjones@xxxxxxxxxx>
>
> I have confirmed this fixes the bug described here:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1061339

Thanks, I have applied it for immediate inclusion.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/