Re: WARNING: CPU: 1 PID: 0 at kernel/time/tick-broadcast.c:668 tick_broadcast_oneshot_control+0x17d/0x190()

From: Stanislaw Gruszka
Date: Tue Feb 11 2014 - 11:28:31 EST


> > I came with a below patch, which also clear pending mask, but perhaps
>
> Fun. I came up with the exact same solution independent of you and I
> tested it on real C1E contaminated hardware.
>
> > oneshot_mask should not be cleared on tick_broadcast_setup_oneshot(),
> > or should be cleared only conditionally, or some other solution is
>
> We can do it unconditionally. It creates consistent state in all
> corner cases.
>
> There are other solutions to the problem, but that needs a major
> rework of the broadcast code. I so wish that this mess would have
> never been necessary at all ...

Thomas, please post/apply patch, which you think is the most
appropriate.

Thanks
Stanislaw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/