Re: [PATCH] x86: fix two sparse warnings in early boot string handling

[David Rientjes]

On Tue, 11 Feb 2014, Paul Gortmaker wrote:

> Fixes:
> 
> arch/x86/boot/compressed/../string.c:60:14: warning: symbol 'atou' was not declared. Should it be static?
> arch/x86/boot/string.c:133:6: warning: symbol 'strstr' was not declared. Should it be static?
> 
> The atou one could be considered a false positive; it seems somehow
> caused by including ./string.c from within /compressed/string.c file.
> However git grep shows only the atou prototype and declaration, so
> it is completely unused and we can hence delete it.
> 

Declaring a prototype in a header file would be pointless if there is no 
current breakage; I don't see why you can't remove strstr() in 
arch/x86/boot/string.c entirely.  What breaks?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/