Re: [PATCH 19/21] fs: Add prototype declaration to header file include/linux/syscalls.h

[Andrew Morton]

On Sun, 9 Feb 2014 18:58:34 +0530 Rashika Kheria <rashika.kheria@xxxxxxxxx> wrote:

> Subject: [PATCH 19/21] fs: Add prototype declaration to header file include/linux/syscalls.h

The subjects are pretty meaningless - this really isn't an "fs" patch.

I'll rewrite it to

Subject: include/linux/syscalls.h: add sys32_quotactl() prototype

> --- a/include/linux/syscalls.h
> +++ b/include/linux/syscalls.h
> @@ -198,6 +198,11 @@ extern struct trace_event_functions exit_syscall_print_funcs;
>  	}								\
>  	static inline long SYSC##name(__MAP(x,__SC_DECL,__VA_ARGS__))
>  
> +#ifdef CONFIG_QUOTACTL_COMPAT
> +asmlinkage long sys32_quotactl(unsigned int cmd, const char __user *special,
> +			       qid_t id, void __user *addr);
> +#endif
> +
>  asmlinkage long sys_time(time_t __user *tloc);
>  asmlinkage long sys_stime(time_t __user *tptr);
>  asmlinkage long sys_gettimeofday(struct timeval __user *tv,

Disagree with the ifdefs.  If we were to do this, syscalls.h would
have a tremendous number of ifdefs in it.  Take a look in
kernel/sys_ni.c.

Removing the ifdefs will cause a compile-time error to be deferred to
link time, which will inconvenience a small number of people a small
number of times.  However it will make the code more readable by a
large number of people a large number of times.  It's a good tradeoff.

--- a/include/linux/syscalls.h~include-linux-syscallsh-add-sys32_quotactl-prototype-fix
+++ a/include/linux/syscalls.h
@@ -198,11 +198,8 @@ extern struct trace_event_functions exit
 	}								\
 	static inline long SYSC##name(__MAP(x,__SC_DECL,__VA_ARGS__))
 
-#ifdef CONFIG_QUOTACTL_COMPAT
 asmlinkage long sys32_quotactl(unsigned int cmd, const char __user *special,
 			       qid_t id, void __user *addr);
-#endif
-
 asmlinkage long sys_time(time_t __user *tloc);
 asmlinkage long sys_stime(time_t __user *tptr);
 asmlinkage long sys_gettimeofday(struct timeval __user *tv,
_

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/