Re: [PATCH v6] mfd: MAX6650/6651 support

[Laszlo Papp]

On Wed, Feb 12, 2014 at 4:42 AM, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote:
> Hi Laszlo,
>
> Sorry for missing out on a couple of points during my earlier review.
> Please see inline.

Np.

> On 12 February 2014 09:32, Laszlo Papp <lpapp@xxxxxxx> wrote:
>> MAX6650/MAX6651 chip is a multi-function device with I2C busses. The
>> chip includes fan-speed regulators and monitors, GPIO, and alarm.
>>
>> This patch is an initial release of a MAX6650/6651 MFD driver that
>> supports to enable the chip with its primary I2C bus that will connect
>> the hwmon, and then the gpio devices for now.
>>
>> Signed-off-by: Laszlo Papp <lpapp@xxxxxxx>
>> ---
> [snip]
>
>> --- /dev/null
>> +++ b/drivers/mfd/max665x.c
>> @@ -0,0 +1,87 @@
>> +/*
>> + * Device access for MAX6650-MAX6651
>> + *
>> + * Copyright(c) 2013 Polatis Ltd.
>> + *
>> + * Author: Laszlo Papp <laszlo.papp@xxxxxxxxxxx>
>> + *
>> + *  This program is free software; you can redistribute  it and/or modify it
>> + *  under  the terms of  the GNU General  Public License as published by the
>> + *  Free Software Foundation;  either version 2 of the  License, or (at your
>> + *  option) any later version.
>> + */
>> +
>> +#include <linux/device.h>
>> +#include <linux/mfd/core.h>
>> +#include <linux/module.h>
>> +#include <linux/i2c.h>
>> +
>> +#include <linux/mfd/max665x-private.h>
>> +
>> +static struct mfd_cell max665x_devs[] = {
>> +       { .name = "max6651-gpio", },
>> +       { .name = "max6650", }, /* hwmon driver */
>> +       {},
>> +};
>> +
>> +const struct regmap_config max665x_regmap_config = {
>> +       .reg_bits = 5,
>> +};
>
> This should be static.

Agree.

>> +static int max665x_probe(struct i2c_client *i2c,
>> +                           const struct i2c_device_id *id)
>> +{
>> +       struct max665x_dev *max665x;
>> +       int ret;
>> +
>> +       max665x = devm_kzalloc(&i2c->dev, sizeof(*max665x), GFP_KERNEL);
>> +       if (!max665x)
>> +               return -ENOMEM;
>> +
>> +       i2c_set_clientdata(i2c, max665x);
>> +       max665x->dev = &i2c->dev;
>> +       max665x->i2c = i2c;
>> +       max665x->map = devm_regmap_init_i2c(i2c, &max665x_regmap_config);
>
> Don't you need to check the return value of devm_regmap_init_i2c?

I personally think I should. I strived for consistency though with
other similar drivers. After this many reviews about such things, it
seems that consistency matters here less than other projects which I
can cope with, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/