Re: [PATCH v6] mfd: MAX6650/6651 support

From: Mark Brown
Date: Wed Feb 12 2014 - 12:50:36 EST


On Wed, Feb 12, 2014 at 04:02:40AM +0000, Laszlo Papp wrote:

> +const struct regmap_config max665x_regmap_config = {
> + .reg_bits = 5,
> +};

This would normally be static too, and I'd *really* expect to see a
val_bits set here. I'm a bit surprised this works without one.

> + mutex_init(&max665x->iolock);

What is this needed for?

Attachment: signature.asc
Description: Digital signature