Re: [PATCH] x86, acpi: LLVMLinux: Remove nested functions from Thinkpad ACPI

From: David Rientjes
Date: Wed Feb 12 2014 - 16:55:00 EST


On Wed, 12 Feb 2014, dl9pf@xxxxxx wrote:

> From: Behan Webster <behanw@xxxxxxxxxxxxxxxxxx>
>
> The only real change is passing in event_mask to the formerly nested functions.
> Otherwise it's just moving around function and macro code.
>
> This is the only place in the Linux kernel where nested functions are still in
> use. Nested functions aren't part of the C standards, and complicate the
> generated code. Although the Linux Kernel has never set out to be entirely C
> standard compliant, it is increasingly compliant to the standard which is
> supported by other compilers such as Clang. The LLVMLinux project is working on
> being able to compile the Linux kernel with Clang. The use of nested functions
> blocks this effort.
>

So this patch is only as a courtesy to clang and you're not complaining
about things like __builtin() functions, typeof, or a ? : b conditional
operators because clang happens to support them?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/