Re: [PATCH] kernel/resource.c: fix sparse non static symbol warning

From: DaeSeok Youn
Date: Thu Feb 13 2014 - 01:20:50 EST


OK. If I send a patch like this again, ChangeLog is written as you comment.

Thanks.
Daeseok Youn.


2014-02-13 11:28 GMT+09:00 David Rientjes <rientjes@xxxxxxxxxx>:
> On Thu, 13 Feb 2014, Daeseok Youn wrote:
>
>> From f8e0752ac80e56bcbfe197a5820692d199822b52 Mon Sep 17 00:00:00 2001
>> From: Daeseok Youn <daeseok.youn@xxxxxxxxx>
>> Date: Thu, 13 Feb 2014 10:11:39 +0900
>> Subject: [PATCH] kernel/resource.c: fix sparse non static symbol warning
>>
>> kernel/resource.c:518:5: warning:
>> symbol 'reallocate_resource' was not declared. Should it be static?
>>
>> Signed-off-by: Daeseok Youn <daeseok.youn@xxxxxxxxx>
>
> Changelog would be better if it said it's only referenced in file scope so
> it can be marked static.
>
> Acked-by: David Rientjes <rientjes@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/