Re: [PATCH] sections, ipvs: Remove useless __read_mostly for ipvs genl_ops

[Simon Horman]

On Sat, Feb 08, 2014 at 08:57:01AM +0100, Andi Kleen wrote:
> const __read_mostly does not make any sense, because const
> data is already read-only. Remove the __read_mostly
> for the ipvs genl_ops. This avoids a LTO
> section conflict compile problem.

Thanks Andi, applied to ipvs-next.

> Cc: Simon Horman <horms@xxxxxxxxxxxx>
> Cc: Patrick McHardy <kaber@xxxxxxxxx>
> Cc: lvs-devel@xxxxxxxxxxxxxxx
> Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>
> ---
>  net/netfilter/ipvs/ip_vs_ctl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
> index 35be035..2a68a38 100644
> --- a/net/netfilter/ipvs/ip_vs_ctl.c
> +++ b/net/netfilter/ipvs/ip_vs_ctl.c
> @@ -3580,7 +3580,7 @@ out:
>  }
>  
>  
> -static const struct genl_ops ip_vs_genl_ops[] __read_mostly = {
> +static const struct genl_ops ip_vs_genl_ops[] = {
>  	{
>  		.cmd	= IPVS_CMD_NEW_SERVICE,
>  		.flags	= GENL_ADMIN_PERM,
> -- 
> 1.8.5.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/