Re: [f2fs-dev] f2fs: f2fs unmount hangs if f2fs_init_acl() fails during mkdir syscall

[Andrey Tsyvarev]

Hi,

> BTW, have you tested the case that added remove_dirty_dir_inode() into the fail path
> of init_inode_metadata?
> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
> index e095a4f..d5a2c9e 100644
> --- a/fs/f2fs/dir.c
> +++ b/fs/f2fs/dir.c
> @@ -375,6 +375,7 @@ put_error:
>          /* once the failed inode becomes a bad inode, i_mode is S_IFREG */
>          truncate_inode_pages(&inode->i_data, 0);
>          truncate_blocks(inode, 0);
> +       remove_dirty_dir_inode(inode);
>   error:
>          remove_inode_page(inode);
>          return ERR_PTR(err);
Yes, i have tested that case. Fail in init_inode_metadata has been 
processed correctly. Thanks.

--
Best regards,

Andrey Tsyvarev

Linux Verification Center, ISPRAS

web:http://linuxtesting.org

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/