Re: [PATCH] x86, acpi: LLVMLinux: Remove nested functions from Thinkpad ACPI

[Henrique de Moraes Holschuh]

On Wed, 12 Feb 2014, dl9pf@xxxxxx wrote:
> From: Behan Webster <behanw@xxxxxxxxxxxxxxxxxx>
> The only real change is passing in event_mask to the formerly nested functions.
> Otherwise it's just moving around function and macro code.
> 
> This is the only place in the Linux kernel where nested functions are still in
> use. Nested functions aren't part of the C standards, and complicate the
> generated code. Although the Linux Kernel has never set out to be entirely C
> standard compliant, it is increasingly compliant to the standard which is
> supported by other compilers such as Clang. The LLVMLinux project is working on
> being able to compile the Linux kernel with Clang. The use of nested functions
> blocks this effort.
> 
> Signed-off-by: Behan Webster <behanw@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Jan-Simon Möller <dl9pf@xxxxxx>
> 
> CC: David Woodhouse <David.Woodhouse@xxxxxxxxx>
> CC: Matthew Garrett <matthew.garrett@xxxxxxxxxx>
> CC: ibm-acpi-devel@xxxxxxxxxxxxxxxxxxxxx
> CC: platform-driver-x86@xxxxxxxxxxxxxxx
> CC: linux-kernel@xxxxxxxxxxxxxxx

Acked-by: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/