Re: 3.14.0-rc2: WARNING: at mm/slub.c:1007

From: Dave Chinner
Date: Thu Feb 13 2014 - 17:26:17 EST


On Thu, Feb 13, 2014 at 11:53:05AM -0800, Christian Kujau wrote:
> Hi,
>
> after upgrading from 3.13-rc8 to 3.14.0-rc2 on this PowerPC G4 machine,
> the WARNING below was printed.
>
> Shortly after, a lockdep warning appeared (possibly related to my
> post to the XFS list yesterday[0]).

Unlikely.

> Even later in the log an out-of-memory error appeared, that may or may not
> be relatd to that WARNING at all but which I'm trying to chase down ever
> since 3.13, but which tends to appear more often lately.
>
> Can anyone take a look if this is something to worry about?

Already fixed upstream:

commit 255d0884f5635122adb23866b242b4ca112f4bc8
Author: David Rientjes <rientjes@xxxxxxxxxx>
Date: Mon Feb 10 14:25:39 2014 -0800

mm/slub.c: list_lock may not be held in some circumstances

Commit c65c1877bd68 ("slub: use lockdep_assert_held") incorrectly
required that add_full() and remove_full() hold n->list_lock. The lock
is only taken when kmem_cache_debug(s), since that's the only time it
actually does anything.

Require that the lock only be taken under such a condition.

Reported-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
Tested-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
Tested-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
Acked-by: Christoph Lameter <cl@xxxxxxxxx>
Cc: Pekka Enberg <penberg@xxxxxxxxxx>
Signed-off-by: David Rientjes <rientjes@xxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>


Cheers,

Dave.

--
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/