Re: [PATCH 0/9] Add MAX_NICE, MIN_NICE and NICE_WIDTH macros in prio.h.

[Dongsheng Yang]

Hi Ingo & Peter,
    What's your opinion on this patchset?

On 02/11/2014 03:34 PM, Dongsheng Yang wrote:
> Hi Peter,
> 	There are lots of hardcoding of -20 and 19 in kernel to represent
> minimum and maximum of nice value currently. This patch set define three
> macros in prio.h and replace some of the hardcoding with them.
>
> 	Please help to take a look at it, thanx :)
>
> Dongsheng Yang (9):
>    sched: Prio: Use DEFAULT_PRIO to define NICE_TO_PRIO and PRIO_TO_NICE.
>    sched: prio: Add 3 macros of MAX_NICE, MIN_NICE and NICE_WIDTH in
>      prio.h.
>    sched: prio: Use NICE_WIDTH macro to avoid using of hard coding of 40
>      and 20 in prio.h.
>    sched: prio: Add spaces before and after operator of '-'.
>    rcu: Use MAX_NICE to replace hard coding of 19.
>    sched: Replace hardcoding of -20 and 19 with MIN_NICE and MAX_NICE.
>    sys: Replace hardcoding of -20 and 19 with MIN_NICE and MAX_NICE.
>    workqueue: Replace hardcoding of -20 and 19 with MIN_NICE and
>      MAX_NICE.
>    trace: Replace hardcoding of 19 with MAX_NICE.
>
>   include/linux/sched/prio.h           | 14 +++++++++-----
>   kernel/rcu/torture.c                 |  8 ++++----
>   kernel/sched/auto_group.c            |  2 +-
>   kernel/sched/core.c                  | 12 ++++++------
>   kernel/sys.c                         |  8 ++++----
>   kernel/trace/ring_buffer_benchmark.c |  6 +++---
>   kernel/workqueue.c                   |  2 +-
>   7 files changed, 28 insertions(+), 24 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/