Re: [PATCH Resend] net: asix: add missing flag to struct driver_info

From: David Miller
Date: Fri Feb 14 2014 - 15:49:03 EST


From: Emil Goode <emilgoode@xxxxxxxxx>
Date: Thu, 13 Feb 2014 19:30:39 +0100

> The struct driver_info ax88178_info is assigned the function
> asix_rx_fixup_common as it's rx_fixup callback. This means that
> FLAG_MULTI_PACKET must be set as this function is cloning the
> data and calling usbnet_skb_return. Not setting this flag leads
> to usbnet_skb_return beeing called a second time from within
> the rx_process function in the usbnet module.
>
> Signed-off-by: Emil Goode <emilgoode@xxxxxxxxx>
> Reported-by: Bjørn Mork <bjorn@xxxxxxx>

Applied and queued up for -stable.

It would be great if there were some way to validate these
callback flags requirements and catch such errors.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/