Re: [RFCv1 2/4] mfd: twl4030-madc: Add DT support and convert to IIO framework

From: Sebastian Reichel
Date: Sun Feb 16 2014 - 04:03:50 EST


Hi Marek,

On Sat, Feb 15, 2014 at 02:31:41PM +0100, Belisko Marek wrote:
> > /*
> > * Phoenix provides 2 interrupt lines. The first one is connected to
> > * the OMAP. The other one can be connected to the other processor such
> > * as modem. Hence two separate ISR and IMR registers.
> > */
> > - madc->imr = (pdata->irq_line == 1) ?
> > + if (pdata)
> > + madc->use_second_irq = pdata->irq_line != 1;
> > + else
> > + madc->use_second_irq = false;
>
> Can we add some property to use second IRQ also in DT?

Sure, a boolean property like this could be added:

ti,system-uses-second-madc-irq;

I did not add support for it initially, since I could not find any
board in the mainline kernel with this setup. If such a board is
added at some later point the driver can be extended easily.

-- Sebastian

Attachment: signature.asc
Description: Digital signature