Re: [PATCH] hwmon: twl4030-madc-hwmon: Add device tree support.

[Guenter Roeck]

On 02/14/2014 06:08 AM, Belisko Marek wrote:
> On Fri, Feb 14, 2014 at 2:31 PM, Mark Rutland <mark.rutland@xxxxxxx> wrote:
> > On Fri, Feb 14, 2014 at 01:20:58PM +0000, Marek Belisko wrote:
> > > Signed-off-by: Marek Belisko <marek@xxxxxxxxxxxxx>
> > > ---
> > >   Documentation/devicetree/bindings/hwmon/twl4030-madc-hwmon.txt |  9 +++++++++
> > >   drivers/hwmon/twl4030-madc-hwmon.c                             | 10 ++++++++++
> > >   2 files changed, 19 insertions(+)
> > >   create mode 100644 Documentation/devicetree/bindings/hwmon/twl4030-madc-hwmon.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/hwmon/twl4030-madc-hwmon.txt b/Documentation/devicetree/bindings/hwmon/twl4030-madc-hwmon.txt
> > > new file mode 100644
> > > index 0000000..e8016d1
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/hwmon/twl4030-madc-hwmon.txt
> > > @@ -0,0 +1,9 @@
> > > +TWL4030 MADC hwmon.
> > > +
> > > +Required properties:
> > > +- compatible: "ti,twl4030-madc-hwmon"
> > > +
> > > +Example:
> > > +madc-hwmon {
> > > +     compatible = "ti,twl4030-madc-hwmon";
> > > +};
> >
> > Huh?
> >
> > What is this a binding for? From a look at the driver in mainline this
> > just calls into functions from the twl4030 madc driver (which doesn't
> > seem to have a binding).
> I post bindings for twl4030-madc [1]. Without probing this driver
> other things will not work (twl4030-madc-battery e.g.).
> Is there better way to handle this situation?

Since you are converting twl4030-madc to be an iio driver,
can't you simply use the iio_hwmon bridge and declare this driver
obsolete ?

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/