Re: [PATCH 1/2] usb: host: remove USB_ARCH_HAS_?HCI

[Alan Stern]

On Sun, 16 Feb 2014, Paul Bolle wrote:

> USB_ARCH_HAS_EHCI, USB_ARCH_HAS_OHCI, and USB_ARCH_HAS_XHCI were made
> obsolete in v3.11. They have not been used ever since. Setting them has
> no effect. They can safely be removed.
> 
> Signed-off-by: Paul Bolle <pebolle@xxxxxxxxxx>
> ---
> Tested with "git grep".
> 
> Note that the comment in this Kconfig file (that is also removed)
> suggests to first remove the select statements for these symbols and
> then the symbols themselves. But I think it makes more sense to first
> delete these three symbols and then remove the selects statements (as
> that is removing a second order effect). But it could just as well be
> done with just one patch, I'd say.

There's a simple reason for not getting rid of the symbols first.  
Doing it that way, as you did, leaves a window in which it's possible
to select a non-existent symbol.  If that's not an error, it ought to
be.

Regardless, for both patches:

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/