Re: [PATCH] printk: Fix discarding of records

[Linus Torvalds]

On Sun, Feb 16, 2014 at 4:50 PM, Kay Sievers <kay@xxxxxxxx> wrote:
>
> That should avoid the overflow, yes. I expect it will not print the
> first line with a prefix, which we probably should.?

Well, it's not printing out the prefix, but it's also not printing out
the whole first part of the line, so quite frankly, I think that's
actually "more correct".

After all, it has already skipped the beginning of the line.
Prepending the prefix, then skipping part of the line, and then
printing the last part, that sounds truly insane, no?

This isn't even new behaviour - that's how it all worked back when it
was all a byte stream (except then it was *purely* about that byte
stream, so it could literally start anywhere in the line, including
partial prefixes etc).

Of course, an alternative approach - if we really want to always have
full lines - is to skip any partial lines at the beginning of the
output entirely.  So not just drop the prefix, but drop the LOG_CONT
parts too. But since (as mentioned), we've never really guaranteed
that the log starts at line boundaries, I'm not sure what the
advantage would really be..

         Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/