Re: [PATCH] printk: Fix discarding of records

From: Banerjee, Debabrata
Date: Sun Feb 16 2014 - 21:38:34 EST


On 2/16/14, 7:41 PM, "Linus Torvalds" <torvalds@xxxxxxxxxxxxxxxxxxxx>
wrote:

>On Sun, Feb 16, 2014 at 4:19 PM, Banerjee, Debabrata
><dbanerje@xxxxxxxxxx> wrote:
>>
>> No that can't be right, the prev value after every loop is the
>>msg->flags
>> from the *last* line in the list, which has no relation to the *first*,
>>so
>> reusing it for the top of the next loop is nonsense.
>
>Please, Debabrata, humor me, and just try the patch.
>
>And try reading the source code. Because your statement is BS.
...
>No, I haven't tested my patch, and maybe it's broken for some subtle
>reason I'm missing too.

Yes my explanation was wrong, your patch works for me. I assumed printing
the prefix was desired, but if not, great.

-Debabrata


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/