Re: [PATCH V5 0/7] cpufreq: suspend early/resume late: dpm_{suspend|resume}()

[Viresh Kumar]

On 15 February 2014 01:52, Stephen Warren <swarren@xxxxxxxxxxxxx> wrote:
> BTW, I also happened to test these on a Tegra114 system, on which there
> is no cpufreq driver, and this series (applied on top of commit
> 9398a10cd964 Merge tag 'regulator-v3.14-rc2') causes the following
> during suspend:

Ahh, that's a obvious bug. Following would fix it, thanks:

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index c13c100..2dfbb7e 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1617,6 +1617,9 @@ void cpufreq_suspend(void)
 {
        struct cpufreq_policy *policy;

+       if (!cpufreq_driver)
+               return;
+
        if (!has_target())
                return;

@@ -1645,6 +1648,9 @@ void cpufreq_resume(void)
 {
        struct cpufreq_policy *policy;

+       if (!cpufreq_driver)
+               return;
+
        if (!has_target())
                return;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/