Re: [PATCH v4 1/3] mfd: Add realtek USB card reader driver

[Roger]

On 02/17/2014 06:02 PM, Lee Jones wrote:
> > > > > > From: Roger Tseng <rogerable@xxxxxxxxxxx>
> > > > > >
> > > > > > Realtek USB card reader provides a channel to transfer command or data to flash
> > > > > > memory cards. This driver exports host instances for mmc and memstick subsystems
> > > > > > and handles basic works.
> > > > > >
> > > > > > Signed-off-by: Roger Tseng <rogerable@xxxxxxxxxxx>
> > > > > > ---
> > > > > >   drivers/mfd/Kconfig          |  10 +
> > > > > >   drivers/mfd/Makefile         |   1 +
> > > > > >   drivers/mfd/rtsx_usb.c       | 760 +++++++++++++++++++++++++++++++++++++++++++
> > > > > >   include/linux/mfd/rtsx_usb.h | 628 +++++++++++++++++++++++++++++++++++
> > > > > >   4 files changed, 1399 insertions(+)
> > > > > >   create mode 100644 drivers/mfd/rtsx_usb.c
> > > > > >   create mode 100644 include/linux/mfd/rtsx_usb.h
> > > > >
> > > > > Applied again, thanks.
> > > > Would you also apply patch 2/3 and 3/3 that to make the device fully
> > > > operational for users? Or should they be applied by maintainers of
> > > > mmc/memstick subsystems?
> > > >
> > > > Chris, would you give some comment?
> > >
> > > I can apply them, but I need the other Maintainer Acks.
> > >
> > > If they are build orthogonal i.e. there are no build dependencies
> > > between them, it's probably better that they go into their associated
> > > trees separately.
> > I think it would be better to apply them together since the later
> > patches really depend on the 1st one,so now we are waiting for Acks
> > from mmc/memstick subsystems.
>
> When you say "depend on", do you mean as a build depenency, or won't
> run without the first patch applied?

The later 2 patches actually invoke symbols defined in the first patch 
and won't compile if it is not applied first. The Kconfig changes for 
the later oness also specified this by "depends on".

I'm not sure if this means "build dependency". Sorry for my unclear words.

> > But there is no one specified for "memstick/host/" in MAINTAINERS.
> > Could anyone else Ack this?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/