Re: [PATCH] x86: Issue a warning if number of present CPUs > maxcpus and CONFIG_HOTPLUG=n

From: Henrique de Moraes Holschuh
Date: Mon Feb 17 2014 - 14:07:21 EST


On Mon, 17 Feb 2014, Petr Tesarik wrote:
> This results in:
>
> total_cpus = 1008 /* this is purely informative, it is *NOT* used
> to size anything */
> possible = 48 /* clamped to nr_cpu_ids */
>
> A warning message (with or without my patch):
> 1024 Processors exceeds NR_CPUS limit of 48
>
> Informative message:
> Allowing 16 CPUs, 32 hotplug CPUs
>
> No other warning (with or without my patch).

I'd rather no warnings were printed at all (user asked for that nr_cpus,
there is no reason to warn him about it), but your patch didn't cause any
_new_ warnings to be printed anyway.

So, please ignore my comment. There's no need to change anything in your
patch on my account.

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/