Re: [PATCH] w1-gpio: handle of_get_gpio() returning -EPROBE_DEFER better

From: zbr
Date: Mon Feb 17 2014 - 20:32:12 EST


Hi

14.02.2014, 02:05, "Uwe Kleine-KÃnig" <u.kleine-koenig@xxxxxxxxxxxxxx>:
> of_get_gpio() might return -EPROBE_DEFER meaning that the driver
> providing the gpio isn't ready yet. If that happens for the first gpio
> the resulting kernel output without this patch is:
>
> ÂÂÂÂÂÂÂÂw1-gpio somename: Failed to parse DT
> ÂÂÂÂÂÂÂÂplatform somename: Driver w1-gpio requests probe deferral
>
> The first message is misleading and so is suppressed with this patch.
>
> Further if determining the gpio to switch the external pullup yields
> -EPROBE_DEFER this error should be passed back to the caller instead of
> just continuing without pullup.
>
> Signed-off-by: Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx>

I'm ok with this patch, but I virtually do not understand what it does :)
Since I know nothing about device trees.

But yet it looks innocent enough to merge.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/