Re: [PATCH v2 0/11] remove cpu_load in rq

From: Alex Shi
Date: Tue Feb 18 2014 - 01:04:33 EST


On 02/18/2014 12:52 PM, Michael wang wrote:
> On 02/17/2014 09:55 AM, Alex Shi wrote:
>> The cpu_load decays on time according past cpu load of rq. The sched_avg also decays tasks' load on time. Now we has 2 kind decay for cpu_load. That is a kind of redundancy. And increase the system load by decay calculation. This patch try to remove the cpu_load decay.
>>
>> There are 5 load_idx used for cpu_load in sched_domain. busy_idx and idle_idx are not zero usually, but newidle_idx, wake_idx and forkexec_idx are all zero on every arch. A shortcut to remove cpu_Load decay in the first patch. just one line patch for this change.
>>
>> V2,
>> 1, This version do some tuning on load bias of target load, to maximum match current code logical.
>> 2, Got further to remove the cpu_load in rq.
>> 3, Revert the patch 'Limit sd->*_idx range on sysctl' since no needs
>>
>> Any testing/comments are appreciated.
>
> Tested on 12-cpu-x86 box with tip/master, ebizzy and hackbench
> works fine, show little improvements for each time's testing.

Thanks a lot for your data!
>
>
> BTW, I got panic while rebooting, but should not caused by
> this patch set, will recheck and post the report later.
>

I reviewed my patch again. Also didn't find suspicious line for the
following rcu stall. Will wait for your report. :)
>

--
Thanks
Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/