Re: [PATCH v2] xen: remove XEN_PRIVILEGED_GUEST

From: Paul Bolle
Date: Tue Feb 18 2014 - 08:14:08 EST


Here I should have added:

From: Michael Opdenacker <michael.opdenacker@xxxxxxxxxxxxxxxxxx>

in order for Michael to show up as author of the patch.

On Tue, 2014-02-18 at 14:07 +0100, Paul Bolle wrote:
> This patch removes the Kconfig symbol XEN_PRIVILEGED_GUEST which is
> used nowhere in the tree.
>
> We do know grub2 has a script that greps kernel configuration files for
> its macro. It shouldn't do that. As Linus summarized:
> This is a grub bug. It really is that simple. Treat it as one.
>
> Besides, grub2's grepping for that macro is actually superfluous. See,
> that script currently contains this test (simplified):
> grep -x CONFIG_XEN_DOM0=y $config || grep -x CONFIG_XEN_PRIVILEGED_GUEST=y $config
>
> But since XEN_DOM0 and XEN_PRIVILEGED_GUEST are by definition equal,
> removing XEN_PRIVILEGED_GUEST cannot influence this test.
>
> So there's no reason to not remove this symbol, like we do with all
> unused Kconfig symbols.
>
> [pebolle@xxxxxxxxxx: rewrote commit explanation.]
> Signed-off-by: Michael Opdenacker <michael.opdenacker@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Paul Bolle <pebolle@xxxxxxxxxx>


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/