Re: [PATCH] nfsd: check passed socket's net matches NFSd superblock's one

[Stanislav Kinsbursky]

18.02.2014 02:19, J. Bruce Fields ÐÐÑÐÑ:
> On Sat, Feb 15, 2014 at 09:51:20AM +0800, Weng Meiling wrote:
> > Hi Bruce,
> >
> > The upstream has merged your git tree for-3.14, but there is no this patch?
> > Do you forget this patch?
>
> Apologies, I'm not sure what happened.
>
> Looking back at it....  The patch causes all my pynfs reboot recovery
> tests to fail.  They're just doing a "systemctl restart
> nfs-server.service", and "systemctl status nfs-server.service" shows in
> part
>
> 	ExecStart=/usr/sbin/rpc.nfsd $RPCNFSDARGS $RPCNFSDCOUNT (code=exited, status=1/FAILURE)
>
> So the patch is causing rpc.nfsd to fail?  No network namespaces should
> be involved.
>
> I haven't investigated any further.

Hi Bruce,
Are you sure, that exactly this patch broke your pynfs tests?
BTW, systemd manipulates namespaces. Maybe the patch revealed some pynfs internal bugs?
What do you think?

> --b.
>
> > Thanks!
> > Weng Meiling
> >
> >
> > On 2014/1/4 6:22, J. Bruce Fields wrote:
> > > On Mon, Dec 30, 2013 at 05:23:59PM +0300, Stanislav Kinsbursky wrote:
> > > > There could be a case, when NFSd file system is mounted in network, different
> > > > to socket's one, like below:
> > > >
> > > > "ip netns exec" creates new network and mount namespace, which duplicates NFSd
> > > > mount point, created in init_net context. And thus NFS server stop in nested
> > > > network context leads to RPCBIND client destruction in init_net.
> > > > Then, on NFSd start in nested network context, rpc.nfsd process creates socket
> > > > in nested net and passes it into "write_ports", which leads to RPCBIND sockets
> > > > creation in init_net context because of the same reason (NFSd monut point was
> > > > created in init_net context). An attempt to register passed socket in nested
> > > > net leads to panic, because no RPCBIND client present in nexted network
> > > > namespace.
> > >
> > > So it's the attempt to use a NULL ->rpcb_local_clnt4?
> > >
> > > Interesting, thanks--applying with a minor fix to logged message.
> > >
> > > --b.


--
Best regards,
Stanislav Kinsbursky
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/