Re: [GIT Pull] timer fixes for 3.14

[Thomas Gleixner]

On Tue, 18 Feb 2014, Preeti Murthy wrote:

> Hi Thomas,
> 
> With regard to the patch: "tick: Clear broadcast pending bit when
> switching to oneshot"
> isn't BROADCAST_EXIT called atleast after initializing the high
> resolution timers while
> handling the broadcast IPI and before re-entering idle? This should
> clear the cpu bit
> in the pending mask right?
> 
> idle()
> |__BROADCAST_ENTER
>     |__halt()
>       |__broadcast_ipi
>           |__init_highres()->clear oneshot mask
>               |__return from interrupt->BROADCAST_EXIT (clear pending mask)

Unfortunately not:

     if (cpumask_test_and_clear_cpu(cpu, tick_broadcast_oneshot_mask)) {
     	  clear pending mask;
     }

>                    |__re-enter idle

Go figure :)
 
Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/