Re: [PATCH] pfuze100-regulator: Revert "regulator: pfuze100: Use of_get_child_by_name"

From: Shawn Guo
Date: Tue Feb 18 2014 - 21:12:51 EST


On Tue, Feb 18, 2014 at 09:58:52PM +0530, Sachin Kamat wrote:
> On 18 February 2014 21:20, Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> wrote:
> > Since commit d7857c42 (regulator: pfuze100: Use of_get_child_by_name) we get
> > the following probe failure:
> >
> > pfuze100-regulator 1-0008: Full layer: 1, Metal layer: 0
> > pfuze100-regulator 1-0008: FAB: 0, FIN: 0
> > pfuze100-regulator 1-0008: regulators node not found
> > pfuze100-regulator: probe of 1-0008 failed with error -22
> >
> > Revert the offending commit so that we can probe the regulator successfully.
>
> I wonder what is different in this case from the ones that I already
> have working
> that is causing this to fail. Can you please tell me which dts file
> you have used
> so that I can see if the way the node is defined is anything different.

When you change to use of_get_child_by_name(), you should change 'np' to
point to dev->of_node too.

Shawn

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/