Re: [PATCH] pfuze100-regulator: Fix of_node_get() parameter

From: Sachin Kamat
Date: Tue Feb 18 2014 - 22:33:28 EST


On 19 February 2014 08:16, Fabio Estevam <festevam@xxxxxxxxx> wrote:
> From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
>
> Since commit d7857c42 (regulator: pfuze100: Use of_get_child_by_name) we get
> the following probe failure:
>
> pfuze100-regulator 1-0008: Full layer: 1, Metal layer: 0
> pfuze100-regulator 1-0008: FAB: 0, FIN: 0
> pfuze100-regulator 1-0008: regulators node not found
> pfuze100-regulator: probe of 1-0008 failed with error -22
>
> Now that of_get_child_by_name() is used we should adjust the device_node pointer
> 'np' to not get the parent node anymore.
>
> Suggested-by: Shawn Guo <shawn.guo@xxxxxxxxxx>
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>

Thanks for the fix Fabio.
Acked-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>

Mark,
There are a few more instances that should be fixed like this one. How would you
prefer to handle them - Resend the complete patch or send just the
incremental fix?

--
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/