Re: [PATCH] staging: android: binder: convert commented messages to pr_debug

From: SeongJae Park
Date: Tue Feb 18 2014 - 22:52:42 EST


Add devel@xxxxxxxxxxxxxxxxxxxx as CC. Sorry if this duplicated mail
bothered your inbox.

On Wed, Feb 19, 2014 at 12:49 PM, SeongJae Park <sj38.park@xxxxxxxxx> wrote:
> 2 debugging messages were just commented out for normal case. Let them
> be activated on debug mode without explicit code modification.
>
> Signed-off-by: SeongJae Park <sj38.park@xxxxxxxxx>
> ---
> drivers/staging/android/binder.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
> index eaec1da..a56f941 100644
> --- a/drivers/staging/android/binder.c
> +++ b/drivers/staging/android/binder.c
> @@ -2553,7 +2553,8 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
> unsigned int size = _IOC_SIZE(cmd);
> void __user *ubuf = (void __user *)arg;
>
> - /*pr_info("binder_ioctl: %d:%d %x %lx\n", proc->pid, current->pid, cmd, arg);*/
> + pr_debug("binder_ioctl: %d:%d %x %lx\n",
> + proc->pid, current->pid, cmd, arg);
>
> trace_binder_ioctl(cmd, arg);
>
> @@ -2787,8 +2788,8 @@ static int binder_mmap(struct file *filp, struct vm_area_struct *vma)
> proc->vma = vma;
> proc->vma_vm_mm = vma->vm_mm;
>
> - /*pr_info("binder_mmap: %d %lx-%lx maps %p\n",
> - proc->pid, vma->vm_start, vma->vm_end, proc->buffer);*/
> + pr_debug("binder_mmap: %d %lx-%lx maps %p\n",
> + proc->pid, vma->vm_start, vma->vm_end, proc->buffer);
> return 0;
>
> err_alloc_small_buf_failed:
> --
> 1.8.3.2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/