Re: [PATCH 01/10] mfd: Add TI LMU driver

From: Lee Jones
Date: Wed Feb 19 2014 - 03:14:07 EST


> >>>>+ pdata->en_gpio = of_get_named_gpio(node, "ti,enable-gpio", 0);
> >>>
> >>>There is a global DT property for this already.
> >>
> >>I've not found it yet, but I agree it looks like general property.
> >>So I'll replace "ti,enable-gpio" with "ti,lmu-en-gpio".
> >
> >Just re-use "gpio-enable". No need for it to be vendor specific.
> >
>
> Got it. Thanks!
>
> This GPIO is used for enabling the device. So, "enable-gpio" is more
> appropriate name, isn't it?

Yes, I wrote it the wrong way round (typo).

Just grep for both, you will see which one to use.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/