Re: [PATCH v2 1/3] usb: chipidea: msm: Add device tree binding information

From: Courtney Cavin
Date: Wed Feb 19 2014 - 12:45:23 EST


On Wed, Feb 19, 2014 at 04:43:22PM +0100, Ivan T. Ivanov wrote:
>
> Hi,
>
> On Tue, 2014-02-18 at 13:26 -0800, Courtney Cavin wrote:
> > On Tue, Feb 18, 2014 at 02:21:19PM +0100, Ivan T. Ivanov wrote:
> > > From: "Ivan T. Ivanov" <iivanov@xxxxxxxxxx>
> > >
> > > Document device tree binding information as required by
> > > the Qualcomm USB controller.
> > >
> > > Signed-off-by: Ivan T. Ivanov <iivanov@xxxxxxxxxx>
> > > ---
> > > .../devicetree/bindings/usb/msm-hsusb.txt | 17 +++++++++++++++++
> >
> > Although you mentioned to Josh that this is intended for "non-standard"
> > Chipidea properties, I don't see any other than requiring that 'dr_mode'
> > must be "peripheral". It would seem that this should all be integrated
> > into a ci3xxx.txt.
>
> Hm, there is no ci3xxx.txt. The closest match is ci-hdrc-imx.txt.
> So it could be ci-hdrc-qcom.txt or my preferred name qcom,ci-hdrc.txt?

Sorry, I was referring to ci13xxx-imx.txt, which was apparently moved to
ci-hdrc-imx.txt. I was recommending to merge the two into one
'ci13xxx.txt', as this binding seems to be a new compatible for the same
basic chip. Now perhaps 'ci-hdrc.txt'.

Although I agree with Josh that this name should be changed, and I think
either of your two suggestions would be acceptable, I would like to at
least discuss the possibility of actually merging the two in this
series.

Comments?

-Courtney
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/