Re: [PATCH] staging: android: binder: convert commented messages to pr_debug

[SeongJae Park]

On Thu, Feb 20, 2014 at 12:24 AM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, Feb 19, 2014 at 12:49:33PM +0900, SeongJae Park wrote:
>> 2 debugging messages were just commented out for normal case. Let them
>> be activated on debug mode without explicit code modification.
>
> Are you sure this doesn't just always send the messages to the debug log
> all the time now?  Again, I'd just leave it alone...

Yes, I sure it will not unless `DEBUG` defined. I tested it again.

Anyway, I know this patch makes just a little, trivial enhancement and
for somebody, it would not looks like enhancement at all. In these case,
I think maintainer's opinion must be respected.
Also, I agree the code as-is just works and not bad.

Thank you for reviewing and your opinion, Greg.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/