Re: [PATCH][RESEND] [media] davinci: vpfe: remove deprecated IRQF_DISABLED

From: Laurent Pinchart
Date: Thu Feb 20 2014 - 06:36:19 EST


Hi Michael,

What's the status of this patch ? Do expect Prabhakar to pick it up, or do you
plan to push all your IRQF_DISABLED removal patches in one go ?

On Monday 09 December 2013 11:16:22 Michael Opdenacker wrote:
> This patch proposes to remove the use of the IRQF_DISABLED flag
>
> It's a NOOP since 2.6.35 and it will be removed one day.
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@xxxxxxxxxxxxxxxxxx>
> Acked-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>
> ---
> drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
> b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c index
> d8ce20d2fbda..cda8388cbb89 100644
> --- a/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
> +++ b/drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c
> @@ -298,7 +298,7 @@ static int vpfe_attach_irq(struct vpfe_device *vpfe_dev)
> {
> int ret = 0;
>
> - ret = request_irq(vpfe_dev->ccdc_irq0, vpfe_isr, IRQF_DISABLED,
> + ret = request_irq(vpfe_dev->ccdc_irq0, vpfe_isr, 0,
> "vpfe_capture0", vpfe_dev);
> if (ret < 0) {
> v4l2_err(&vpfe_dev->v4l2_dev,
> @@ -306,7 +306,7 @@ static int vpfe_attach_irq(struct vpfe_device *vpfe_dev)
> return ret;
> }
>
> - ret = request_irq(vpfe_dev->ccdc_irq1, vpfe_vdint1_isr, IRQF_DISABLED,
> + ret = request_irq(vpfe_dev->ccdc_irq1, vpfe_vdint1_isr, 0,
> "vpfe_capture1", vpfe_dev);
> if (ret < 0) {
> v4l2_err(&vpfe_dev->v4l2_dev,
> @@ -316,7 +316,7 @@ static int vpfe_attach_irq(struct vpfe_device *vpfe_dev)
> }
>
> ret = request_irq(vpfe_dev->imp_dma_irq, vpfe_imp_dma_isr,
> - IRQF_DISABLED, "Imp_Sdram_Irq", vpfe_dev);
> + 0, "Imp_Sdram_Irq", vpfe_dev);
> if (ret < 0) {
> v4l2_err(&vpfe_dev->v4l2_dev,
> "Error: requesting IMP IRQ interrupt\n");

--
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/