Re: [PATCH] sched: keep quiescent cpu out of idle balance loop

[Peter Zijlstra]

On Thu, Feb 20, 2014 at 05:17:04PM +0800, Lei Wen wrote:
> +++ b/kernel/sched/fair.c
> @@ -6883,6 +6883,13 @@ void nohz_balance_enter_idle(int cpu)
>  	if (!cpu_active(cpu))
>  		return;
>  
> +	/*
> +	 * If this cpu is kept outside of root domain, we don't bother
> +	 * to ask it for nohz balance.
> +	 */
> +	if (!cpumask_test_cpu(cpu, this_rq()->rd.span))

 rd->span

Otherwise the compiler gets upset. Fixed it.

> +		return;
> +
>  	if (test_bit(NOHZ_TICK_STOPPED, nohz_flags(cpu)))
>  		return;
>  
> -- 
> 1.8.3.2
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/