Re: WARNING at kernel/workqueue.c:829 wq_worker_waking_up+0x53/0x70()

From: Lan Tianyu
Date: Thu Feb 20 2014 - 09:46:15 EST


This is a multi-part message in MIME format. On 02/20/2014 10:31 PM, Jiri Olsa wrote:
On Thu, Feb 20, 2014 at 09:28:26PM +0800, Lan Tianyu wrote:
On 02/19/2014 06:49 AM, Tejun Heo wrote:
Hello,

On Mon, Feb 17, 2014 at 06:19:00PM +0100, Oleg Nesterov wrote:
acpi_processor_set_throttling() plays with set_cpus_allowed_ptr(current),
this is obviously wrong, and the worker is bound.

Umm... yeah, anything running on workqueues shouldn't be diddling with
cpu affinity. The function even has /* FIXME: use work_on_cpu() */ in
it. I suppose it's about time to actually implement that?

Thanks.


Hi Jiri:
Could you try this patch which reworks ACPI processor throttling
with work_on_cpu()?

hum, I've got difficulties to apply it..

[jolsa@krava2 linux-perf]$ git am /tmp/wq/
Applying: WARNING at kernel/workqueue.c:829 wq_worker_waking_up+0x53/0x70()
fatal: corrupt patch at line 8
Patch failed at 0001 WARNING at kernel/workqueue.c:829 wq_worker_waking_up+0x53/0x70()

jirka

Sorry. Please try the attachment again.

--
Best Regards
Tianyu Lan