Re: WARNING at kernel/workqueue.c:829 wq_worker_waking_up+0x53/0x70()

[Oleg Nesterov]

On 02/20, Oleg Nesterov wrote:
>
> On 02/20, Lan Tianyu wrote:
> >
> > @@ -1096,7 +1112,6 @@ int acpi_processor_set_throttling(struct acpi_processor *pr,
> >  		return -ENODEV;
> >  	}
> >
> > -	cpumask_copy(saved_mask, &current->cpus_allowed);
>
> Yes, but the patch forgets to kill alloc_cpumask_var(&saved_mask)
> and saved_mask itself ;)

And it seems that acpi_processor_set_throttling() doesn't need
online_throttling_cpus at all. It could use
for_each_cpu_and(cpu_online_mask, p_throttling->shared_cpu_map).

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/