Re: [PATCH] rename HAS_IOPORT to HAS_IOPORT_MAP

From: Arnd Bergmann
Date: Thu Feb 20 2014 - 10:24:34 EST


On Thursday 20 February 2014, Uwe Kleine-KÃnig wrote:
> If the renamed symbol is defined lib/iomap.c implements ioport_map and
> ioport_unmap and currently (nearly) all platforms define the port
> accessor functions outb/inb and friend unconditionally. So
> HAS_IOPORT_MAP is the better name for this. Consequently NO_IOPORT is
> renamed to NO_IOPORT_MAP.
>
> The motivation for this change is to reintroduce a symbol HAS_IOPORT
> that signals if outb/int et al are available. I will address that
> at least one merge window later though to keep surprises to a minimum
> and catch new introductions of (HAS|NO)_IOPORT.
>
> The changes in this commit were done using:
>
> $ git grep -l -E '(NO|HAS)_IOPORT' | xargs perl -p -i -e 's/\b((?:CONFIG_)?(?:NO|HAS)_IOPORT)\b/$1_MAP/'
>
> Signed-off-by: Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx>

Thanks for taking up that work, I had a similar patch series
some years ago but never followed through with getting it upstream.
If there are no objections, I hope Andrew can queue it up for -mm.
Unfortunately I can't think of a good way to split up the patch
into smaller units that could go through subsystem maintainer
trees, since we want to start reusing the symbol as soon as possible.

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/