Re: [PATCH] w1: bundle reply if the request was bundled

From: Evgeniy Polyakov
Date: Thu Feb 20 2014 - 16:07:39 EST


Hi

19.02.2014, 11:19, "David Fries" <david@xxxxxxxxx>:
> A program can bundle multiple messages and commands together when
> making one wire requests, which is going to be much more efficient
> than sending lots of little packets one write at a time.  With this
> change the kernel will then bundle responses to requests that were
> bundled, where it's probably even more important because programs will
> typically execute select or a poll operation between reading packets,
> which takes additional context switches.


Your approach and patch seem correct, but I worry about how old commands are processed.
Do I get it right, that replies to old non-bundle commands are queued back instead of sending immediately,
but since it is not bundle but single command, queued reply is being sent 'almost' immediately?
Basically, nothing changed to old clients, but there is new way to send batch requests now?

And please make indent less paranoid about line length, it is really hard to read some lines,
which were broken into pieces just because of that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/