Re: [PATCH 7/9] afs: don't use PREPARE_WORK

[Tejun Heo]

On Thu, Feb 20, 2014 at 10:00:05PM +0000, David Howells wrote:
> Tejun Heo <tj@xxxxxxxxxx> wrote:
> 
> > PREPARE_[DELAYED_]WORK() are being phased out.  They have few users
> > and a nasty surprise in terms of reentrancy guarantee as workqueue
> > considers work items to be different if they don't have the same work
> > function.
> 
> Why so?  Isn't the work item address sufficient to distinguish them?

Because we ended up introducing deadlocks through work items which are
freed and then recycled.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/