Re: [PATCH v1.3 1/11] arcmsr: Revise interrupt service routine to fix command timeout

From: Dan Carpenter
Date: Fri Feb 21 2014 - 02:20:38 EST


On Fri, Feb 21, 2014 at 10:56:34AM +0800, éæé wrote:
> From: Ching <ching2048@xxxxxxxxxxxx>
>
> Rewrite interrupt service routine to fix command timeout on controller
> too heavy loading.
>
> Singed-off-by: Ching <ching2048@xxxxxxxxxxxx>

This email is still line wrapped I'm afraid. It doesn't apply.

> ---
>
> diff -uprN a/drivers/scsi/arcmsr/arcmsr_attr.c
> b/drivers/scsi/arcmsr/arcmsr_attr.c
> --- a/drivers/scsi/arcmsr/arcmsr_attr.c 2014-02-07 01:47:24.000000000 +0800
> +++ b/drivers/scsi/arcmsr/arcmsr_attr.c 2014-01-10 20:28:48.000000000 +0800
> -#define ARCMSR_SCSI_INITIATOR_ID
> 255
> +#define ARCMSR_SCSI_INITIATOR_ID 255

Please do white space changes in a separate change set so that the logic
changes are easier to review.

Use "git citool". Highlight the lines with white space changes and then
right click and select "Stage lines for commit". It is a very useful
tool.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/