Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute

[Peter Hurley]

On 02/21/2014 09:52 AM, Hannes Reinecke wrote:
> On 02/21/2014 03:48 PM, Josh Boyer wrote:
> > On Thu, Feb 20, 2014 at 6:52 PM, Greg Kroah-Hartman
> > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > > 3.13-stable review patch.  If anyone has any objections, please let me know.
> > >
> > > ------------------
> > >
> > > From: Hannes Reinecke <hare@xxxxxxx>
> > >
> > > commit d8a5dc3033af2fd6d16030d2ee4fbd073460fe54 upstream.
> > >
> > > The 'active' sysfs attribute should refer to the currently active tty
> > > devices the console is running on, not the currently active console.
> > >
> > > The console structure doesn't refer to any device in sysfs, only the tty
> > > the console is running on has.  So we need to print out the tty names in
> > > 'active', not the console names.
> > >
> > > This resolves an issue on s390 platforms in determining the correct
> > > console device to use.
> >
> > Just to be double sure this is seen, Ray points out that it breaks
> > current plymouth because the heuristic changed.  Hold off on this one?
> Without this patch systemd won't present a login console for s390.
> I'd prefer fixing plymouth.

Not an option.

As I said before, the old interface should be left alone and
forked to present a new interface that systemd can use to
get what it expects.

Regards,
Peter Hurley

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/