Re: [PATCH] EDAC, MCE, AMD: Fix code to prevent NULL dereference

[Aravind Gopalakrishnan]

On 2/21/2014 8:23 AM, Borislav Petkov wrote:
> On Thu, Feb 20, 2014 at 05:13:51PM +0100, Borislav Petkov wrote:
> > On Thu, Feb 20, 2014 at 10:07:33AM -0600, Aravind Gopalakrishnan wrote:
> > > Tested the above a final time on local machine and it works fine..
> > Ok, I'll queue it up with your Tested-by. Thanks.
> So I dropped the family check altogether, modulo the warning that says
> that we're getting loaded on unsupported hardware. We want to allow
> loading, even if we don't have family ops.
>
> Ok?

Yes, makes sense.

> --
> From: Borislav Petkov <bp@xxxxxxx>
> Subject: [PATCH] MCE, AMD: Fix decoding module loading on unsupported hw
>
> We want to still be able to issue some error information on systems for
> which there is no decoding support (think older distro kernels here,
> for example). Therefore, we allow module registration but skip the
> per-family bank-specific decoders and issue the general information
> only, i.e.:
>
> [   46.822828] [Hardware Error]: Error Status: Uncorrected, software containable error.
> [   46.822846] [Hardware Error]: CPU:0 (15:30:0) MC0_STATUS[-|UE|-|-|-|-|-]: 0xa000000000010f0f
> [   46.822858] [Hardware Error]: cache level: L3/GEN, mem/io: GEN, mem-tx: GEN, part-proc: GEN (timed out)
>
> with the hope that it still contains helpful useful bits.
>
> Suggested-by: Aravind Gopalakrishnan <aravind.gopalakrishnan@xxxxxxx>
> Tested-by: Aravind Gopalakrishnan <aravind.gopalakrishnan@xxxxxxx>
> Signed-off-by: Borislav Petkov <bp@xxxxxxx>
> ---
>   drivers/edac/mce_amd.c | 65 +++++++++++++++++++++++++-------------------------
>   1 file changed, 33 insertions(+), 32 deletions(-)

Works for me:

[    0.321623] Huh? What family is it: 0x15?!
[    0.321629] MCE: In-kernel MCE decoding enabled.
...
[   79.294568] [Hardware Error]: Uncorrected, software containable error.
[   79.294587] [Hardware Error]: CPU:0 (15:30:0) 
MC0_STATUS[-|UE|-|-|-|-|-]: 0xa000000000010f0f
[   79.294602] [Hardware Error]: cache level: L3/GEN, mem/io: GEN, 
mem-tx: GEN, part-proc: GEN (timed out)

Thanks,
-Aravind

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/