Re: [PATCH] fs, kernel: Support disabling the uselib syscall

[Andrew Morton]

On Fri, 21 Feb 2014 10:11:06 -0800 Josh Triplett <josh@xxxxxxxxxxxxxxxx> wrote:

> uselib hasn't been used since libc5; glibc does not use it.  Support
> turning it off.
> 
> When disabled, also omit the load_elf_library implementation from
> binfmt_elf.c, which only uselib invokes.
> 
> bloat-o-meter:
> add/remove: 0/4 grow/shrink: 0/1 up/down: 0/-785 (-785)
> function                                     old     new   delta
> padzero                                       39      36      -3
> uselib_flags                                  20       -     -20
> sys_uselib                                   168       -    -168
> SyS_uselib                                   168       -    -168
> load_elf_library                             426       -    -426
> 

The patch disables CONFIG_USELIB by default.  This important decision
should be mentioned and justified in the changelog, please.

> +#ifdef CONFIG_USELIB

I wonder if CONFIG_SYS_USELIB would be a better identifier.  We haven't
done anything consistent here.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/