Re: [PATCH v5 10/33] iommu, irq: Allocate irq_desc for dmar_msi with local node

From: Yinghai Lu
Date: Sat Feb 22 2014 - 02:45:29 EST


On Fri, Feb 21, 2014 at 7:14 PM, Jiang Liu <jiang.liu@xxxxxxxxxxxxxxx> wrote:

> Seems there is no such protection on IA64 side. I feel create_irq_nr()
> returns 0 for error is a little risky, 0 may be
> a valid IRQ number on other platforms(no sure about this).
> Thanks!

in [PATCH] ia64, irq: Add dummy create_irq_nr()

+unsigned int create_irq_nr(unsigned int from, int node)
+{
+ int irq = create_irq();
+
+ if (irq < 0)
+ irq = 0;
+
+ return irq;
+}
+

so that from is ignored.

create_irq_nr() is only with x86 and ia64.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/